Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ACK runtime v0.38.0, code-generator v0.38.1 #58

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Update to ACK runtime v0.38.0, code-generator v0.38.1 #58

merged 1 commit into from
Sep 6, 2024

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Aug 29, 2024

Update to ACK runtime v0.38.0, code-generator v0.38.1

NOTE:
This PR increments the release version of service controller from v1.0.15 to v1.0.16

Once this PR is merged, release v1.0.16 will be automatically created for sqs-controller

Please close this PR, if you do not want the new patch release for sqs-controller

stdout for make build-controller:

building ack-generate ... ok.
==== building sqs-controller ====
Copying common custom resource definitions into sqs
Building Kubernetes API objects for sqs
Generating deepcopy code for sqs
Generating custom resource definitions for sqs
Building service controller for sqs
Generating RBAC manifests for sqs
Running gofmt against generated code for sqs
Updating additional GitHub repository maintenance files
==== building sqs-controller release artifacts ====
Building release artifacts for sqs-v1.0.16
Generating common custom resource definitions
Generating custom resource definitions for sqs
Generating RBAC manifests for sqs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Aug 29, 2024
@ack-prow ack-prow bot requested review from a-hilaly and jaypipes August 29, 2024 17:16
@ack-prow ACK Prow
Copy link

ack-prow bot commented Aug 30, 2024

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sqs-verify-attribution 56d82e1 link true /test sqs-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelhtm
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2024
@a-hilaly
Copy link
Member

a-hilaly commented Sep 6, 2024

/lgtm

@ack-prow ACK Prow
Copy link

ack-prow bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Sep 6, 2024
@ack-prow ack-prow bot merged commit 05e831f into main Sep 6, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

@jaypipes jaypipes Awaiting requested review from jaypipes

Assignees

@a-hilaly a-hilaly

@michaelhtm michaelhtm

Labels
approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ack-bot @michaelhtm @a-hilaly